Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a Common Pitfalls section to README #415

Closed
wants to merge 2 commits into from
Closed

docs: add a Common Pitfalls section to README #415

wants to merge 2 commits into from

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Sep 15, 2022 •
edited

... and say "do not put spaces in your home directory"

This was the consensus answer for 134 in Vancouver

Fixes #134

@ckerr
docs: add a Common Pitfalls section to README
1eb23a1 
say do not put spaces in your home directory
dsanders11
dsanders11 approved these changes Sep 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ckerr @dsanders11
Update README.md
053866a 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
MarshallOfSound
MarshallOfSound reviewed Sep 17, 2022
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we codify this too? Just in e init maybe, checking process.env.HOMEDIR for a space or whatever the x-platform way of doing that is

@ckerr ckerr marked this pull request as draft September 19, 2022 15:27
@codebytere
Copy link
Member

@ckerr do you still want to move this forward?

@dsanders11
Copy link
Member

#444 could be combined with this, IMO.

@ckerr ckerr closed this Jan 10, 2024
@ckerr ckerr deleted the docs/no-spaces branch January 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@dsanders11 dsanders11 dsanders11 approved these changes

@codebytere codebytere Awaiting requested review from codebytere

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

documentation should say "do not put spaces in your home directory"
4 participants
@ckerr @codebytere @dsanders11 @MarshallOfSound