Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate broker api client implementations into one module #74

Open
clavin opened this issue Jun 28, 2021 · 0 comments
Open

Consolidate broker api client implementations into one module #74

clavin opened this issue Jun 28, 2021 · 0 comments
Labels
module:broker refactor
Projects
Sprints

Comments

@clavin
Copy link
Member

clavin commented Jun 28, 2021

Currently, there are approximately three different implementations (or parts of impls) of clients to communicate with the broker:

  • The GitHub bot module
  • The runner module
  • The broker's own tests

It would be better to consolidate these into their own @electron/bugbot-broker-client module that has its own unit tests and integration tests with the broker server module.
@ckerr ckerr added this to Backlog in Sprints Jul 6, 2021
@ckerr ckerr moved this from Unsorted to Backlog - Technical Debt in Sprints Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:broker refactor
Projects
Sprints
Backlog - Technical Debt
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clavin @erickzhao