Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential security vulnerability: runner should sanitize env before spawning electron-fiddle #64

Open
ckerr opened this issue Jun 16, 2021 · 1 comment
Labels
🪲 bug Something isn't working module:runner
Projects

Comments

@ckerr
Copy link
Member

ckerr commented Jun 16, 2021

We pass a lot of bugbot's config into the web services via environment variables, including potentially in the future secrets/tokens. When a runner calls spawn() to start electron-fiddle, we should sanitize the environment variables so that none of that is visible to user-supplied test gists.

@ckerr ckerr added the 🪲 bug Something isn't working label Jun 16, 2021
@MarshallOfSound
Copy link
Member

The issue is that just sanitizing the env on the spawned process isn't enough to prevent the spawned process reading that env. E.g. ps e -ww -p {pid} lets you read env for any other pid.

The env of the runner can't contain any secrets at all or the runner needs to run the apps in an even more isolated environment

@ckerr ckerr added this to Nice-to-Have for this Sprint in Sprints Jul 6, 2021
@ckerr ckerr moved this from Nice-to-Have for this Sprint to Backlog - Technical Debt in Sprints Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working module:runner
Projects
Sprints
Backlog - Technical Debt
Development

No branches or pull requests

3 participants