Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker needs to intervene if a runner times out #48

Open
ckerr opened this issue Jun 3, 2021 · 1 comment
Open

broker needs to intervene if a runner times out #48

ckerr opened this issue Jun 3, 2021 · 1 comment
Labels
module:broker ✨ enhancement New feature or request
Projects

Comments

@ckerr
Copy link
Member

ckerr commented Jun 3, 2021

Currently, if a runner disappears in the middle of a job, that job will just hang indefinitely.

The broker should notice when a runner isn't communicating. It could definitely amend the log, and it perhaps should also mark the job as unclaimed so that another runner can try.

@ckerr ckerr added the ✨ enhancement New feature or request label Jun 4, 2021
@ckerr ckerr added this to Unsorted in Sprints Jul 6, 2021
@ckerr ckerr moved this from Unsorted to Backlog - Features in Sprints Jul 13, 2021
@ckerr ckerr moved this from Backlog - Features to Backlog - Technical Debt in Sprints Jul 19, 2021
@ckerr
Copy link
Member Author

ckerr commented Aug 6, 2021

This is still a real issue. We should probably add a timeout in the broker to mark a claimed task as unclaimed if it sits idle for more than a couple of minutes.

Now, if there's just something really wrong with a fiddle or with a runner, we could get into an endless loop of [ runner claims -> runner crashes -> runner is restarted -> broker unclaims ]. We may want to consider a circuit breaker of some sort to ensure this pathological case doesn't run more than a few loops.

Related to #176.

@ckerr ckerr moved this from Backlog - Technical Debt to Backlog - Bugs in Sprints Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:broker ✨ enhancement New feature or request
Projects
Sprints
Backlog - Bugs
Development

No branches or pull requests

2 participants