Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react-native-reanimated v2.0.0 #228

Open
FlorBosch opened this issue Dec 10, 2021 · 0 comments
Open

Add support for react-native-reanimated v2.0.0 #228

FlorBosch opened this issue Dec 10, 2021 · 0 comments

Comments

@FlorBosch
Copy link

This version is different from the current supported version (react-native-reanimated_v1.3.0+). According to the documentation:

Reanimated 2 is primarily built in C++ using Turbo Modules infrastructure which is not yet completely deployed in React Native (specifically on Android). Because of that the installation of new Reanimated requires additional steps apart from just adding a dependency to package.json.

This means that the following method needs to be overridden in the ElectrodeReactNativeHost, something that the current ReactPlugin interface doesn't provide.

      @Override
      protected JSIModulePackage getJSIModulePackage() {
        return new ReanimatedJSIModulePackage(); // <- add
      }

Besides the new JSIModulePackage there is another difference in how the android module is generated for this dependency: during the package creation the android-npm folder is added as the android one (createNPMPackage.sh#L82). As you can see the ReanimatedProxyPackage.java is empty in this case, and this is because the aar packages are generated directly and picked up during the build time.

Screenshot 2021-12-10 at 13 35 35

We haven't found a way to support all these changes needed for react-native-reanimated v2.0.0 in our manifest yet.
Any help is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant