Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the disputed area of Western Sahara #6618

Open
madsnedergaard opened this issue Apr 3, 2024 · 5 comments
Open

Separate the disputed area of Western Sahara #6618

madsnedergaard opened this issue Apr 3, 2024 · 5 comments
Assignees
Labels
geometry Issues related to the map geometry help wanted

Comments

@madsnedergaard
Copy link
Member

Description

We currently show the Moroccan-controlled area of Western Sahara as part of Morocco.
Since the actual ownership of this areas is disputed and unclear, it would make sense to merge the area into a full Western Sahara zone.

See our guide on how to edit the geometries if you want to pick this up :)

Screenshot 2024-04-03 at 09 37 47

More details on the conflict:

How Google Maps shows the area:

Screenshot 2024-04-03 at 09 37 03

@madsnedergaard madsnedergaard added help wanted geometry Issues related to the map geometry labels Apr 3, 2024
@ryanguomd
Copy link

Hi, I would like to work on this!

@VIKTORVAV99
Copy link
Member

VIKTORVAV99 commented Apr 14, 2024

Hi, I would like to work on this!

Hi and thanks!

I'll assign you the issue.

@ryanguomd
Copy link

I'm getting a yarn install error when I try to run yarn && yarn update-world in the 'web' folder.
Screenshot 2024-04-15 at 4 47 21 PM

@VIKTORVAV99
Copy link
Member

VIKTORVAV99 commented Apr 15, 2024

I'm getting a yarn install error when I try to run yarn && yarn update-world in the 'web' folder.

Screenshot 2024-04-15 at 4 47 21 PM

Ah it appears this wiki page has slipped us by. We shifted to using PNPM a while back so it should work with that instead.

Double check your node version as well, we have not tested that any packages work on node 21 as we only increment LTS versions (even version numbers).

@ryanguomd
Copy link

Double check your node version as well, we have not tested that any packages work on node 21 as we only increment LTS versions (even version numbers).

Thanks, I'm using node v20 now. I changed the borders in an untitled project on QGIS, but I'm a bit confused on how I can see if I'm actually directly editing the world.geojson file. Also, running pnpm generate-world gives this error:

Screenshot 2024-04-15 at 8 03 42 PM

Couldn't find much from debugging so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geometry Issues related to the map geometry help wanted
Projects
None yet
Development

No branches or pull requests

3 participants