Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Enable responseActionsSentinelOneV2Enabled feature flag in main #183664

Merged

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented May 16, 2024

Summary

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0 labels May 16, 2024
@paul-tavares paul-tavares self-assigned this May 16, 2024
@paul-tavares
Copy link
Contributor Author

/ci

@paul-tavares paul-tavares marked this pull request as ready for review May 16, 2024 19:04
@paul-tavares paul-tavares requested review from a team as code owners May 16, 2024 19:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@pzl pzl requested review from joeypoon and removed request for pzl May 16, 2024 19:23
@gergoabraham
Copy link
Contributor

/ci

@gergoabraham
Copy link
Contributor

(added /ci command, bc looks like the build system doesn't start the pipeline when we mark a draft PR ready.)

@paul-tavares paul-tavares enabled auto-merge (squash) May 17, 2024 18:05
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM once the timeout is set to 5m 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit 4b2afc8 into elastic:main May 21, 2024
35 checks passed
@paul-tavares paul-tavares deleted the task/olm-9343-enable-s1-v2-ff-in-main branch May 21, 2024 19:59
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.14 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 183664

Questions ?

Please refer to the Backport tool documentation

@paul-tavares
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

paul-tavares added a commit to paul-tavares/kibana that referenced this pull request May 21, 2024
…bled` feature flag in `main` (elastic#183664)

## Summary

- Enables the `responseActionsSentinelOneV2Enabled` feature flag for
`main`
- This same FF was enabled already in 8.14 via:
elastic#182384
- Changes the background task for completing response actions to have an
initial timeout of `5m` (instead of `20m`)

(cherry picked from commit 4b2afc8)

# Conflicts:
#	x-pack/plugins/security_solution/common/experimental_features.ts
#	x-pack/plugins/security_solution/server/endpoint/lib/response_actions/complete_external_actions_task.ts
paul-tavares added a commit that referenced this pull request May 22, 2024
…neV2Enabled` feature flag in `main` (#183664) (#183960)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Security Solution][Endpoint] Enable
`responseActionsSentinelOneV2Enabled` feature flag in `main`
(#183664)](#183664)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paul
Tavares","email":"56442535+paul-tavares@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-21T19:59:51Z","message":"[Security
Solution][Endpoint] Enable `responseActionsSentinelOneV2Enabled` feature
flag in `main` (#183664)\n\n## Summary\r\n\r\n- Enables the
`responseActionsSentinelOneV2Enabled` feature flag for\r\n`main`\r\n-
This same FF was enabled already in 8.14
via:\r\nhttps://github.com//pull/182384\r\n- Changes the
background task for completing response actions to have an\r\ninitial
timeout of `5m` (instead of
`20m`)","sha":"4b2afc8461ae2d1804b1daef8b79eca39c3b3905","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.14.0","v8.15.0"],"number":183664,"url":"#183664
Solution][Endpoint] Enable `responseActionsSentinelOneV2Enabled` feature
flag in `main` (#183664)\n\n## Summary\r\n\r\n- Enables the
`responseActionsSentinelOneV2Enabled` feature flag for\r\n`main`\r\n-
This same FF was enabled already in 8.14
via:\r\nhttps://github.com//pull/182384\r\n- Changes the
background task for completing response actions to have an\r\ninitial
timeout of `5m` (instead of
`20m`)","sha":"4b2afc8461ae2d1804b1daef8b79eca39c3b3905"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183664
Solution][Endpoint] Enable `responseActionsSentinelOneV2Enabled` feature
flag in `main` (#183664)\n\n## Summary\r\n\r\n- Enables the
`responseActionsSentinelOneV2Enabled` feature flag for\r\n`main`\r\n-
This same FF was enabled already in 8.14
via:\r\nhttps://github.com//pull/182384\r\n- Changes the
background task for completing response actions to have an\r\ninitial
timeout of `5m` (instead of
`20m`)","sha":"4b2afc8461ae2d1804b1daef8b79eca39c3b3905"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0 v8.15.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants