[Security Assistant] Show license upgrade CTA within new flyout #183576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spong
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @spong |
patrykkopycinski
approved these changes
May 16, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
…tic#183576) ## Summary This is a fix for showing the license upgrade CTA when using the new flyout experience with the Security Assistant. To test, downgrade your license from `trial` to `basic` in Stack Management and view that the CTA is now back. The `New Chat` and `Expand Conversations` button are now also disabled if `!isAssistantAvailable`. > [!NOTE] > No logic around determining if the assistant should be shown has changed, so all existing tests around `assistantAvailability` are still in place and relevant. This was a surgical fix, and we short-circuit to show this UI if `!isAssistantAvailable`. This is a functional change to ESS only, as Serverless completely hides the assistant when unavailable (`essentials` productTier) as originally implemented in elastic#164763. Before / After: <p align="center"> <img width="300" src="https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec" /> <img width="295" src="https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5" /> </p> (cherry picked from commit dff2d29)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2024
#183576) (#183583) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Assistant] Show license upgrade CTA within new flyout (#183576)](#183576) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Garrett Spong","email":"spong@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-16T04:14:19Z","message":"[Security Assistant] Show license upgrade CTA within new flyout (#183576)\n\n## Summary\r\n\r\nThis is a fix for showing the license upgrade CTA when using the new\r\nflyout experience with the Security Assistant.\r\n\r\nTo test, downgrade your license from `trial` to `basic` in Stack\r\nManagement and view that the CTA is now back.\r\n\r\nThe `New Chat` and `Expand Conversations` button are now also disabled\r\nif `!isAssistantAvailable`.\r\n\r\n> [!NOTE]\r\n> No logic around determining if the assistant should be shown has\r\nchanged, so all existing tests around `assistantAvailability` are still\r\nin place and relevant. This was a surgical fix, and we short-circuit to\r\nshow this UI if `!isAssistantAvailable`.\r\n\r\nThis is a functional change to ESS only, as Serverless completely hides\r\nthe assistant when unavailable (`essentials` productTier) as originally\r\nimplemented in #164763 / After:\r\n<p align=\"center\">\r\n<img width=\"300\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec\"\r\n/> <img width=\"295\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5\"\r\n/>\r\n</p>","sha":"dff2d294d7083f23cc53b375fba542a89ee38558","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team: SecuritySolution","Feature:Security Assistant","v8.14.0","v8.15.0"],"title":"[Security Assistant] Show license upgrade CTA within new flyout","number":183576,"url":"#183576 Assistant] Show license upgrade CTA within new flyout (#183576)\n\n## Summary\r\n\r\nThis is a fix for showing the license upgrade CTA when using the new\r\nflyout experience with the Security Assistant.\r\n\r\nTo test, downgrade your license from `trial` to `basic` in Stack\r\nManagement and view that the CTA is now back.\r\n\r\nThe `New Chat` and `Expand Conversations` button are now also disabled\r\nif `!isAssistantAvailable`.\r\n\r\n> [!NOTE]\r\n> No logic around determining if the assistant should be shown has\r\nchanged, so all existing tests around `assistantAvailability` are still\r\nin place and relevant. This was a surgical fix, and we short-circuit to\r\nshow this UI if `!isAssistantAvailable`.\r\n\r\nThis is a functional change to ESS only, as Serverless completely hides\r\nthe assistant when unavailable (`essentials` productTier) as originally\r\nimplemented in #164763 / After:\r\n<p align=\"center\">\r\n<img width=\"300\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec\"\r\n/> <img width=\"295\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5\"\r\n/>\r\n</p>","sha":"dff2d294d7083f23cc53b375fba542a89ee38558"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183576","number":183576,"mergeCommit":{"message":"[Security Assistant] Show license upgrade CTA within new flyout (#183576)\n\n## Summary\r\n\r\nThis is a fix for showing the license upgrade CTA when using the new\r\nflyout experience with the Security Assistant.\r\n\r\nTo test, downgrade your license from `trial` to `basic` in Stack\r\nManagement and view that the CTA is now back.\r\n\r\nThe `New Chat` and `Expand Conversations` button are now also disabled\r\nif `!isAssistantAvailable`.\r\n\r\n> [!NOTE]\r\n> No logic around determining if the assistant should be shown has\r\nchanged, so all existing tests around `assistantAvailability` are still\r\nin place and relevant. This was a surgical fix, and we short-circuit to\r\nshow this UI if `!isAssistantAvailable`.\r\n\r\nThis is a functional change to ESS only, as Serverless completely hides\r\nthe assistant when unavailable (`essentials` productTier) as originally\r\nimplemented in #164763 / After:\r\n<p align=\"center\">\r\n<img width=\"300\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/92b512b6-9cec-4f83-948a-d1e101bdc9ec\"\r\n/> <img width=\"295\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2946766/c3e39812-27e6-4c4f-ba4c-efb70adff6b5\"\r\n/>\r\n</p>","sha":"dff2d294d7083f23cc53b375fba542a89ee38558"}}]}] BACKPORT--> Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for showing the license upgrade CTA when using the new flyout experience with the Security Assistant.
To test, downgrade your license from
trialtobasicin Stack Management and view that the CTA is now back.The
New ChatandExpand Conversationsbutton are now also disabled if!isAssistantAvailable.Note
No logic around determining if the assistant should be shown has changed, so all existing tests around
assistantAvailabilityare still in place and relevant. This was a surgical fix, and we short-circuit to show this UI if!isAssistantAvailable.This is a functional change to ESS only, as Serverless completely hides the assistant when unavailable (
essentialsproductTier) as originally implemented in #164763.Before / After: