Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] 🐞 Flyout causes an error when closed quickly after navigation #179880

Closed
mohamedhamed-ahmed opened this issue Apr 3, 2024 · 2 comments · Fixed by #180837 or #182026
Closed

[Dataset quality] 🐞 Flyout causes an error when closed quickly after navigation #179880

mohamedhamed-ahmed opened this issue Apr 3, 2024 · 2 comments · Fixed by #180837 or #182026
Assignees
@awahab07
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented Apr 3, 2024 •
edited

✅ Steps To Reproduce

  1. Navigate to Dataset Quality page
  2. Open the flyout for any dataset
  3. Click on the Open in Logs Explorer button
  4. Navigate back to the dataset page, through the browser back button for example
  5. Press the ESC button on the keyboard to close the flyout.

🎥 Demo

bug.mov
@mohamedhamed-ahmed mohamedhamed-ahmed added bug Fixes for quality problems that affect the customer experience Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Apr 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Apr 15, 2024
@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this issue Apr 15, 2024
Merged
@mohamedhamed-ahmed
Copy link
Contributor Author

The issue still happens when the ESC button is pressed on the keyboard after navigating back to the dataset quality page with the flyout opened.

@mohamedhamed-ahmed mohamedhamed-ahmed removed their assignment Apr 24, 2024
@yngrdyn yngrdyn changed the title [Dataset quality] Flyout causes an error when closed quickly after navigation [Dataset quality] 🐞 Flyout causes an error when closed quickly after navigation Apr 25, 2024
@awahab07 awahab07 self-assigned this Apr 25, 2024
@awahab07 awahab07 mentioned this issue Apr 29, 2024
Merged
awahab07 added a commit that referenced this issue May 2, 2024
@awahab07
[Dataset quality] Fix flyout error when closed after navigation (#182026
312523e 
)

Fixes #179880

## Summary

The PR fixes the error reported in the parent issue by making sure
Dataset Quality flyout more receptive to `undefined` flyout state.
yuliacech pushed a commit to yuliacech/kibana that referenced this issue May 3, 2024
@awahab07 @yuliacech
[Dataset quality] Fix flyout error when closed after navigation (elas…
c293cb8 
…tic#182026)

Fixes elastic#179880

## Summary

The PR fixes the error reported in the parent issue by making sure
Dataset Quality flyout more receptive to `undefined` flyout state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awahab07 awahab07

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@awahab07 @mohamedhamed-ahmed @elasticmachine