Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Improve permission error response on SLO create API #181899

Open
kdelemme opened this issue Apr 26, 2024 · 3 comments
Open

[SLO] Improve permission error response on SLO create API #181899

kdelemme opened this issue Apr 26, 2024 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@kdelemme
Copy link
Contributor

kdelemme commented Apr 26, 2024

Summary

When an error happens because of a missing permission on the user's role, we should surface it to the user

https://elastic.slack.com/archives/C046NR8UQBS/p1714146343878759?thread_ts=1714037309.548819&cid=C046NR8UQBS

@kdelemme kdelemme added Team:obs-ux-management Observability Management User Experience Team Feature:SLO labels Apr 26, 2024
@jasonrhodes
Copy link
Member

Based on my reading of the linked Slack conversation, it sounds like we may also want to look at how that try/catch handles the logic for "undo" in the catch, because it seems like it was failing to undo and causing a new error, which sounds avoidable? Do I understand that correctly?

@kdelemme
Copy link
Contributor Author

kdelemme commented May 8, 2024

Yes we can do better on the rollback: smaller try/catch block that can be rollback with more granularity.

@jasonrhodes jasonrhodes added the bug Fixes for quality problems that affect the customer experience label May 8, 2024
@kdelemme
Copy link
Contributor Author

@jasonrhodes created this story for the rollback issue: #183677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

No branches or pull requests

2 participants