Remove "Save to library" option when creating a panel in the dashboard

[teresaalvarezsoler]

Why is this important
Most panels should be by-value so we will make it the default and only option during panel creation. Users will still be able to find the “Save to Library” option in the panel menu for those panels where this option makes sense (see image below)

Requirements
Remove the options to save to library when the panel is created from a Dashboard for the following panel types

• Lens
• Maps
• Custom visualizations
• TSVB
• Agg based

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[ThomThomson]

@teresaalvarezsoler I don't think we should make the Links panel by value by default. By definition, the links panel is usually shared between multiple Dashboards -the Dashboards that it links off to. If we made it by value by default, authors would either need to manually add it to the library, or keep multiple separate versions of the links in sync.

[nreese]

with the migration to react embeddables, we could move the entire map editing experience into dashboard for by-value maps. Should this be a part of this effort?

[mwtyang]

@ThomThomson Dashboards should be the root entity where users should interact with our visualizations. By providing users "easy-button" to recreate by-reference visualizations, it creates problems that users may not realize like difficulties in managing dashboard-as-a-code or sharing dashboards across spaces. Basically, it's not feasible to do these things with dashboards with by-reference visualizations. If users do need to share visualizations across multiple dashboards, then they can still do it via adding to visualization library from the initial dashboard. By the way, this is the only way you can share visualizations across multiple dashboards in Grafana as well.

cc @thomasneirynck @timductive

[teresaalvarezsoler]

I will get some telemetry to make the decision about the links panel. We made it by-ref by default assuming that 80% of the time users will need to re-use it in different dashboards.

with the migration to react embeddables, we could move the entire map editing experience into dashboard for by-value maps. Should this be a part of this effort?

@nreese this is a great idea, what do you have in mind? Will that imply removing the Maps section entirely? (users will still be able to find them in the Visualize library list page)

[nreese]

@nreese this is a great idea, what do you have in mind? Will that imply removing the Maps section entirely? (users will still be able to find them in the Visualize library list page)

No, maps application would still exist as is today. The only difference would be that for by-value maps, the editing experience would be completely contained in dashboard. The map would show add layer button and edit layer buttons when in edit mode and user has write permissions. Click would open a flyout similiar to lens ESQL flyout allowing users to create/edit layers.

[teresaalvarezsoler]

This enhancement is included in this other issue in the Viz team roadmap #181982. It seems it's more natural that the Viz team takes care of it so I'm removing it form our board.