Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Unskip Unhandled Promise Rejection tests #114992

Closed
crob611 opened this issue Oct 14, 2021 · 2 comments
Closed

[Dashboard] Unskip Unhandled Promise Rejection tests #114992

crob611 opened this issue Oct 14, 2021 · 2 comments
Labels
Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
Dashboard

Comments

@crob611
Copy link
Contributor

crob611 commented Oct 14, 2021

As part of the upgrade to node 16 (#110684), some of the dashboard tests had to be skipped as they were throwing unhandle promise rejections.

We should go back and unskip those tests and properly handle the promise rejections.
@crob611 crob611 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture Feature:Canvas labels Oct 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added this to Inbox in Canvas Oct 14, 2021
@crob611 crob611 added Feature:Dashboard Dashboard related features and removed Feature:Canvas labels Oct 14, 2021
@kibanamachine kibanamachine added this to Inbox in Dashboard Oct 14, 2021
@kibanamachine kibanamachine removed this from Inbox in Canvas Oct 14, 2021
@ThomThomson ThomThomson mentioned this issue Jan 30, 2023
Merged
@nreese
Copy link
Contributor

nreese commented Jan 30, 2023

Closing, duplicate of #126000

@nreese nreese closed this as completed Jan 30, 2023
Dashboard automation moved this from Inbox to Done Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Dashboard
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @crob611 @elasticmachine