[EuiToolTip] Close tooltips on escape keydown #7751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1Copenut do you think this interaction needs to be documented in our docs, or that we need extra screen reader text explaining it? |
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
I think what we have for now is just enough. The benefit will be for keyboard users primarily. It's a pretty common pattern to use |
|
Sounds great, thanks! |
mgadewoll
approved these changes
May 14, 2024
|
Thanks y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7741
QA
Escapekey and confirm that the tooltip is dismissed/hiddenGeneral checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobileand screenreader modes- [ ] Added documentation- [ ] Props have proper autodocs (using@defaultif default values are missing) and playground toggles- [ ] Checked Code Sandbox works for any docs examplesjest andcypress tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)