Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] [EuiSelectable] allow for highlighting a custom fragment when using custom option matcher #7711

Open
Tracked by #182611
mbondyra opened this issue Apr 25, 2024 · 1 comment
Assignees

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Apr 25, 2024

While testing #7709 I noticed that while passing a custom optionMatcher we cannot highlight the substring that is matched. It'd be good to add it in some way.

Here the fragment get highlighted:
Screenshot 2024-04-25 at 14 11 27

Here it is not, as it comes from the custom matcher check:
Screenshot 2024-04-25 at 14 11 43

@cee-chen
Copy link
Member

cee-chen commented Apr 25, 2024

@tkajtoch do you mind baking this into #7709? Also @mbondyra feel free to leave this as a comment on the PR itself since it hasn't been merged yet!

edit: Oh wait, super sorry, I think I misread the ask. This makes sense to do as a follow-up PR instead of in the same PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants