-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storybook] update Storybook utils to ensure merging of control configs #7611
Merged
mgadewoll
merged 12 commits into
elastic:main
from
mgadewoll:storybook/7583-support-merged-story-control-configs
Mar 26, 2024
Merged
[Storybook] update Storybook utils to ensure merging of control configs #7611
mgadewoll
merged 12 commits into
elastic:main
from
mgadewoll:storybook/7583-support-merged-story-control-configs
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-utils ensure config updates are merged instead of overwritten - adds common helper _updateArgTypes to update argTypes via utils
mgadewoll
added
documentation
Issues or PRs that only affect documentation - will not need changelog entries
skip-changelog
labels
Mar 21, 2024
mgadewoll
commented
Mar 22, 2024
…t-merged-story-control-configs
cee-chen
reviewed
Mar 25, 2024
cee-chen
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for answering all my annoying questions!! 😁 Feel free to address the returned object discussion if you feel like it or just merge if you're OK with it as is!
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Issues or PRs that only affect documentation - will not need changelog entries
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7583
This PR updates the internal Storybook utils
hideStorybookControls
,disableStorybookControls
andmoveStorybookControlsToCategory
to ensure they merge control table updates into the Preview/Component/Story config instead of potentially overwriting existing settings.To ensure this, the functions now take the config as an argument and add the new control setting onto it.
This means the following things:
The proposed way of using the utils:
Additionally, this PR updates all usages of those three util functions inside available story files.
QA
color
,fill
andsize
are moved to the categoryEuiButton props
gh pr checkout 7611
facet_button_stories.tsx
fullWidth
todisableStorybookControls(meta, ['buttonRef']);
on line 56EuiButtonEmpty props
AND it's now disabled instead of typeboolean
css
,className
anddata-test-subj
are not displayed on any story control table (globally hidden inpreview.tsx
)