Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Sort fields panel shows long names centralised on Safari #7551

Open
machadoum opened this issue Mar 5, 2024 · 1 comment
Open

Comments

@machadoum
Copy link
Member

machadoum commented Mar 5, 2024

Describe the bug
When displayAsText is long and the panel has a scroll bar (only on Safari), the field name is horizontally centralised.

Impact and severity
Very Low

Environment and versions

  • EUI version: 93.2.0
  • React version: 18.2.0
  • Kibana version (if applicable): 8.13
  • Browser: Safari 17.3.1
  • Operating System: macOS 14.3.1

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://zndqlz.csb.app
  2. Click on 'Sort fields'
  3. Click on 'Pick fields to sort by'
  4. See error

Expected behavior
The field name should be displayed in a single line, like on Chrome.

Minimum reproducible sandbox
https://codesandbox.io/p/sandbox/restless-browser-zndqlz

Screenshots

Safari

Screenshot 2024-03-05 at 15 39 34

Chrome

Screenshot 2024-03-05 at 15 54 55

Additional context
This bug was found during Kibana QA testing: elastic/kibana#177873

@machadoum machadoum added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Mar 5, 2024
@cee-chen cee-chen added data grid and removed ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Mar 7, 2024
@cee-chen cee-chen self-assigned this Mar 7, 2024
@cee-chen cee-chen removed their assignment Mar 11, 2024
@cee-chen
Copy link
Member

cee-chen commented Mar 11, 2024

This is a strange CSS bug caused by the browser scrollbar that can't be easily fixed without downsides. I spiked it out in #7567 but ended mildly disliking the visual tradeoff it caused in popovers that did not have scrollbars.

IMO, we should opt for redesigning this popover wholly (see Caroline's UI suggestion in #5894 (comment)) and resolving it that way.

If we don't end up implementing the new design, we could resurrect my PR in a pinch if absolutely needed, but since this is low priority/severity, I'm not sure we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants