Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator Naming Missleading #155

Open
6 tasks
SevKohler opened this issue Dec 18, 2020 · 1 comment
Open
6 tasks

Generator Naming Missleading #155

SevKohler opened this issue Dec 18, 2020 · 1 comment
Labels
invalid This doesn't seem right

Comments

@SevKohler
Copy link
Contributor

Configuration information

  • EHRbase version: 0.14
  • openEHR_SDK version: generator 1.0.0
  • Archie version:
  • PostgreSQL version:
  • Java Runtime version: 11
  • Operating System version:

Steps to reproduce

run generator for this template https://ckm.highmed.org/ckm/templates/1246.169.743 .

For KontaktAction if wanted to setKontaktZuEinemBestaetigtenFallDefiningCode the class for the method parameter is AelterOderGleich65JahreAltDefiningCode. This is a naming from another defining code which is misplaced here, values are the same so logically its correct. Nevertheless should be smt like KontaktZuEinemBestaetigtenFallDefiningCode or choose a more generic name if used in different context so its not misleading.

Definition of Done

  • The defect is checked by an unit or an integration test (Robot)
  • Merge Request approved
  • Unit tests passed
  • Build without errors
  • Release notes prepared
  • No additional runtime warnings
@SevKohler SevKohler added bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Dec 18, 2020
@stefanspiska
Copy link
Contributor

I could generate a new enum if the node Name are different but then we would have lots of enums representing the same value-set
https://loinc.org/LL365-8/ : Yes|No

sadly there dos not seam to be an option in opt to define a name for the code_list Elements

So I would need to implement in the generator config a mapping. something like:

Yes_No= LA33-6;LA32-8

You can however simple rename the class after generation. Since the dto <-> composition mapping dos not depend on names (only the annotations)

@birgerhaarbrandt @serefarikan
Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants