Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably unnecessary check for Intl #294

Open
rimace opened this issue Mar 12, 2021 · 0 comments
Open

Probably unnecessary check for Intl #294

rimace opened this issue Mar 12, 2021 · 0 comments

Comments

@rimace
Copy link

rimace commented Mar 12, 2021

The check and error message at DNSCheckValidation.php:38 seems unnecessary. Because if the extension doesn't exist, the function is provided by the package symfony/polyfill-intl-idn you defined as dependency in your composer.json.
As symfony/polyfill-intl-idn is a "hard" dependency and not just a suggestion, ! function_exists('idn_to_ascii') will never return true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants