Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can calvin fetch npm dependencies? If possible, how? #13

Open
iku000888 opened this issue Aug 6, 2017 · 5 comments
Open

Can calvin fetch npm dependencies? If possible, how? #13

iku000888 opened this issue Aug 6, 2017 · 5 comments

Comments

@iku000888
Copy link
Contributor

Sorry for occupying the bandwidth.
I raised an issue as I could not figure this one out by my self as a node.js newbie...

@eginez
Copy link
Owner

eginez commented Aug 17, 2017

Hey this is something I have been thinking about for a bit. It is not suppoted however you can use npm directly and everything else should just work.
I'll start thinking about ways to add this into calvin

@iku000888
Copy link
Contributor Author

Hey @eginez Thanks!

Just some feedback:
After figuring out that stuff in node_modules gets picked up (either by calvin or lumo not sure), everything was straightforward.
In retrospect I think I could have figured it out on my own with a line or two in the README.
Would be happy to add a section on the README if that is fine with you.

@eginez
Copy link
Owner

eginez commented Aug 19, 2017

By all means! Send me a PR and we'll add it to the readme

iku000888 added a commit to iku000888/calvin that referenced this issue Aug 22, 2017
@iku000888
Copy link
Contributor Author

I recently read this post, and thought if calvin would fetch stuff automatically it would make sense to use the :npm-deps key because ClojureScript proper supports it.

https://clojurescript.org/news/2017-07-12-clojurescript-is-not-an-island-integrating-node-modules

@eginez
Copy link
Owner

eginez commented Sep 9, 2017

I did some investigation no how to fetch npm modules programatically https://stackoverflow.com/questions/15957529/can-i-install-a-npm-package-from-javascript-running-in-node-js/15957574#15957574.

Since it now supports npm dependencies it is feasible now to download from clojars and from npm directly at once and not have a to run those tools independently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants