Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto resize if threejs scene are detected. #129

Closed
eee-c opened this issue Feb 20, 2018 · 0 comments
Closed

Auto resize if threejs scene are detected. #129

eee-c opened this issue Feb 20, 2018 · 0 comments
Assignees
@eee-c

Comments

@eee-c
Copy link
Owner

eee-c commented Feb 20, 2018 •
edited

I think we'll want to inject something like this in the preview HTML: mrdoob/three.js#69 (comment)

It should also have guard clauses to check for the presence of top-level camera and renderer variables. Not sure that there is much we can do for multiple camera setups tho.
@eee-c eee-c self-assigned this Mar 31, 2018
eee-c added a commit that referenced this issue Mar 31, 2018
@eee-c
Initial auto-resize
04aa6b9 
This works (yay!). But we still need conditionals to check
for perspective mode, and to ensure that the code declares a renderer
and camera. Also need to test that the orthographic code works.

Paired with @terrasea

#129
@eee-c eee-c closed this as completed in e87109c May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eee-c eee-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eee-c