Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.go assumes schema format by appending "-audio" or "-video" during query #21

Open
JamKelley22 opened this issue Apr 27, 2021 · 0 comments

Comments

@JamKelley22
Copy link

Problem:

While --video_schema and --audio_schema name can be anything when running run_backfill.py there is an underlying assumption that "-audio" and "-video" are on the end of the schema name. run_backfill.py does not automatically append them when running the containers.

Impact:

After successfully inserting videoframes or audioframes into a session, the query to retrieve them is not as expected or impossible to form. If the original schema appended "-audio" or "-video" (eg. schema: "edusense-audio") then only using the first part of the schema will succeed. If the original schema did not append this then the frames are not queryable (eg. schema: "0.1.0" transforms to "0.1.0-audio").

Solution:

In storage/query/resolver/session.go lines 123 and 165 need to have the second argument updated to remove the string concatenation.

Side effects:

Any arguments automatically passed into scripts like run_backfill.py will need to be updated to match the fully qualified expected schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant