Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer 2 #106

Open
j3j5 opened this issue Oct 27, 2020 · 6 comments
Open

Composer 2 #106

j3j5 opened this issue Oct 27, 2020 · 6 comments

Comments

@j3j5
Copy link

j3j5 commented Oct 27, 2020

Now that Composer 2 has been released I was wondering what you think is the best approach to make it available on the image.
Not sure if it makes sense to have both versions available for a while or if it'd be better to include version 2 directly since they are mostly compatible. An advantage is that we can remove prestissimo from the dependencies, for the rest, I've been testing it on the image and there's nothing else that seems to be causing issues.

I guess there will be people for which there may be some incompatibilities but if they've been using an up-to-date version of this image they probably have been getting warnings about it for a while.

What do you think? I can help create the PR with whatever approach you think is best.

Cheers!

@romainnorberg
Copy link

Hello @j3j5

Temporarily, on an existing project, we are testing the following solution:

project:
  services:
    - mariadb:10.3
  image: edbizarro/gitlab-ci-pipeline-php:7.4-alpine
  script:
    - composer -V # Composer version 1.10.15 2020-10-13 15:59:09
    - sudo composer self-update --2 
    - composer -V 
    # The "hirak/prestissimo" plugin (installed globally) was skipped because it requires a Plugin API version ("^1.0.0") that does not match your Composer installation ("2.0.0"). You may need to run composer update with the "--no-plugins" option. 
    # Composer version 2.0.3 2020-10-28 15:50:55

I think it would be good to be able to switch from V1 to V2 and vice-versa.

@j3j5
Copy link
Author

j3j5 commented Oct 30, 2020

Hi @romainnorberg , that exactly has been my approach, to upgrade from the container, but I guess it'd be better if we could choose w/o having to download the upgrade/downgrade every time. Personally, I'd go for using composer2 only and leave the downgrade (as you mention above) as an option, but I guess it's @edbizarro call.

@j3j5
Copy link
Author

j3j5 commented Nov 4, 2020

I see there's an open PR #108, I'm fine with that approach 👍

@rsereir
Copy link

rsereir commented Nov 4, 2020

@j3j5 I confirm you before doing my PR, I saw the message from @romainnorberg and i use this to solve my CI

@C0kkie
Copy link

C0kkie commented Feb 18, 2021

@edbizarro Possible that composer 2 is still not working?

@almightynassar
Copy link

Is there anything that is being done about this?

Is there a better alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants