Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure external windows for browser and electron #28

Open
lucas-koehler opened this issue Feb 25, 2022 · 1 comment
Open

Configure external windows for browser and electron #28

lucas-koehler opened this issue Feb 25, 2022 · 1 comment
Labels
multi-window-mvp Implemention of the multi window MVP

Comments

@lucas-koehler
Copy link

The newly opened windows should only have a minimal frame showing the externalized widget. This has to be configured for electron and browser windows.
We want to remove all unneeded UI elements that extend over the minimal window/popup frame:

  • Windows should still have controls to minimize, maximize, close
  • Remove location/url and status bars
  • Remove all window menus (especially relevant for electron)

If this results in different window opening handling for browser and electron in the WidgetExtractionHandler, the window opening code should be extracted to a new service (e.g. could be named ExternalWindowFactory) that is implemented for browser and electron. It is then injected into the WidgetExtractionHandler and used to create new windows.

In electron, this might need adaptions of window creation handling in the electron backend. Good starting points are the ElectronMainApplication and TheiaElectronWindowFactory to look into this.

@lucas-koehler lucas-koehler added the multi-window-mvp Implemention of the multi window MVP label Feb 25, 2022
@lucas-koehler
Copy link
Author

I am looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-window-mvp Implemention of the multi window MVP
Projects
None yet
Development

No branches or pull requests

1 participant