Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cert Manager Handling #50

Open
Mtze opened this issue Mar 6, 2024 · 1 comment
Open

Cert Manager Handling #50

Mtze opened this issue Mar 6, 2024 · 1 comment

Comments

@Mtze
Copy link

Mtze commented Mar 6, 2024

Hi everyone,

I'm currently playing with your Helm charts and i think the current handling of certificates in the base chart is suboptimal.

The base chart always installs a production ClusterIssuer (even if there might already be one that should be used for theia) and assumes that a second, self-signed Issuer has to be installed as well. I guess this was implemented that way to simplify the dev setup, but for production use cases I think the certificate handling should be handled separately, of at least be configurable.

If you agree with my suggestion, I'd start implementing that and open an PR.

@jfaltermeier
Copy link
Contributor

Hi, I agree that we should not force install the issuers, especially since we already allow using different issuers via the helm values.
So maybe having two additional values with which we can skip each of them would be great.
I would still like to have the option to install both issuers or either of them using our charts.

Please note that the self-signed issuer may be used for the cluster-internal custom-resource-conversion-service as well (https://github.com/eclipsesource/theia-cloud-helm/blob/main/charts/theia-cloud-crds/templates/conversion-webhook-certificate.yaml), so this one is not just for testing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants