Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OAuth Provider Mock to Use in Tests #2697

Open
kolotu opened this issue Nov 11, 2020 · 1 comment
Open

Create OAuth Provider Mock to Use in Tests #2697

kolotu opened this issue Nov 11, 2020 · 1 comment

Comments

@kolotu
Copy link
Member

kolotu commented Nov 11, 2020

No description provided.

@ghost
Copy link

ghost commented Nov 24, 2020

#2529 already required me to write some basic provider mocks.

  • In the unit tests, the IOAuthProviderRegistry is mocked, and contains a mocked IOAuthProvider that "looks like" GitHub (since all test users are mock GitHub users to start with).
  • In the integration tests, the IOAuthProviderRegistry is replaced with a @Primary mock bean in the configuration, and it contains the same mock "Github-ish" IOauthProvider as in the unit tests.

I think these changes provide a base for this (#2697) task, but they are not sufficient on their own to fulfil its goal, i.e. in my opinion, to be able to emulate more complex situations, first and foremost username collision with different OAuth providers.

Bottomline, I think this task should be started once #2529 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant