Basic UI: fix refresh of hidden/visible image/chart #4534
Conversation
|
@resetnow : please confirm that I don't need anymore to provide the file smarthome.js in the web directory but only the one in the web-src directory ? If you can review, that would be cool. |
That's correct.
Later today. |
| _t.visible = state; | ||
| }; | ||
|
|
||
| _t.disactivateRefresh = function() { |
There was a problem hiding this comment.
You probably meant deactivateRefresh
| _t.disactivateRefresh = function() { | ||
| if (interval !== undefined) { | ||
| clearInterval(interval); | ||
| interval = undefined; |
There was a problem hiding this comment.
JS type are weird but I think here null is more suitable as it's used in the rest of the code
There was a problem hiding this comment.
Ok I will change that.
| String url = chartUrl + "&t=" + (new Date()).getTime(); | ||
| String url; | ||
| if (!itemUIRegistry.getVisiblity(w)) { | ||
| url = "images/none.png"; |
There was a problem hiding this comment.
Feels a bit weird here, should be a static const maybe?
| interval = setInterval(function() { | ||
| if (_t.image.clientWidth === 0) { | ||
| clearInterval(interval); | ||
| return; | ||
| } | ||
| _t.image.setAttribute("src", _t.url + "&t=" + Date.now()); | ||
| if (_t.image.getAttribute("src").startsWith(_t.url)) { |
There was a problem hiding this comment.
Couldn't figure out what this is for.
There was a problem hiding this comment.
It is to avoid a refresh of the image using the proxied URL when the image was set with a raw data for example.
There was a problem hiding this comment.
Maybe I should rather set a variable to store the information whether we should refresh or not.
|
@resetnow : I have taken into account all your comments except one that remains to be considered. |
|
@resetnow : everything is now ok and working well. |
|
@resetnow If you can approve the changes, we should be good to merge! |
This reverts commit d3301aa.
Fixes #4492
Fixes #4507
Ignore refresh when inappropriate
Signed-off-by: Laurent Garnier lg.hc@free.fr