This repository has been archived by the owner on May 7, 2020. It is now read-only.
Enhance rule interpretation errors #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
| throw new RuntimeException( | ||
| "The name '" + featureCall.toString() + "' cannot be resolved to an item or type."); | ||
| if (featureCall instanceof XMemberFeatureCall) { | ||
| throw new ScriptExecutionException(new ScriptError( |
There was a problem hiding this comment.
There was a problem hiding this comment.
argh, good spot! No idea why there were tabs, but that's history now 😉
There was a problem hiding this comment.
There was a problem hiding this comment.
Awesome, thanks for the hint! I started wondering already how you spotted them...
There was a problem hiding this comment.
Check out https://github.com/brunocvcunha/awesome-userscripts/blob/master/README.md#github
In combination with the above I can recommend https://github.com/jerone/UserScripts/tree/master/Github_Commit_Whitespace#readme to not loose focus
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
kaikreuzer
approved these changes
Nov 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #4317.
This improves the logged error messages as following:
Class cast exception:
becomes
Unknown member:
becomes