Add support for Sonos One player #4429
Add support for Sonos One player #4429
Conversation
xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd"> | ||
|
||
<!-- Player ONE Thing Type --> | ||
<thing-type id="One" listed="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be better "ONE" in capitals (to be in sync with the PLAYXs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well - it could be - but the the discovery has to be tuned too because the player announces itself as 'One' and not 'ONE'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discovery code could ignore the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd agree that it would be better to harden the discovery code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real Name of Play 1 is "PLAY:1" and the real name of the one is "One" and NOT "ONE". So i recommend to use the real name for the ID. Sonos changed their pattern: http://www.sonos.com/de-de/shop/one.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but then these lines are clearly wrong in the first place: https://github.com/eclipse/smarthome/pull/4429/files#diff-148f59c83d8c2a479dea48c22dd67b70R10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new entries in the translation files, somethiong similar to
thing-type.sonos.CONNECT.label = CONNECT
thing-type.sonos.CONNECT.description = Représente un lecteur pré-ampli Sonos CONNECT
If you don't know how to translate, put the line in comments.
<channel id="sleeptimer" typeId="sleeptimer" /> | ||
<channel id="currenttransporturi" typeId="currenttransporturi" /> | ||
<channel id="currenttrackuri" typeId="currenttrackuri" /> | ||
</channels> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no line-in in the One ? If line-in is present, take example on the PLAY:5.
If "One" is kept as thing type id, there is nothing to change in the discovery code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to use the correct spelling "One" throughout the PR, especially in user facing texts.
Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>
Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/sonos-one-discovered-as-zoneplayer-solved/39834/3 |
Add support for Sonos One player
Signed-off-by: Ivaylo Ivanov ivivanov.bg@gmail.com