This repository has been archived by the owner on May 7, 2020. It is now read-only.
[UI] Charts Enhancements: Themes, DPI, legend hiding #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hreichert
force-pushed
the
4288-charts-enhancements
branch
3 times, most recently
from
575dddc
to
e14c21f
Compare
…#4288 Signed-off-by: Holger Reichert <mail@h0lger.de>
hreichert
changed the title
hreichert
force-pushed
the
4288-charts-enhancements
branch
from
e14c21f
to
0d743a2
Compare
kaikreuzer
approved these changes
Sep 25, 2017
|
Thank you @kaikreuzer |
|
Time to prepare the PR for openhab-core now :-) |
|
Sure, here you go: openhab/openhab-core#215 |
mueller-ma
added a commit
to mueller-ma/openhab.android
that referenced
this pull request
Sep 29, 2017
This commit enhances charts to support themes, scale legend according to dpi and create option to hide legend Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
mueller-ma
added a commit
to mueller-ma/openhab.android
that referenced
this pull request
Sep 30, 2017
This commit enhances charts to support themes, scale legend according to dpi and create option to hide legend Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
digitaldan
pushed a commit
to openhab/openhab-android
that referenced
this pull request
Oct 8, 2017
* Make use of eclipse-archived/smarthome#4291 This commit enhances charts to support themes, scale legend according to dpi and create option to hide legend Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com> * Read legend setting from oh server Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com> * Use Boolean Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/charts-are-not-working-as-before-anymore-broken/41208/41 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some enhancements to the ChartServlet, DefaultChartProvider, REST API, BasicUI/ClassicUI to support the following things:
dpiparameter for dynamic sizes based on DPIlegendparameter to hide/show the chart legendPlease see issue #4288 for all details.
The first comment has a up2date description.
❗ This breaks the OH1 compatibility layer:
org.openhab.ui.chart.internal.ChartProviderDelegateIf this gets merged, I create a PR in openhab/openhab-core
Renderings
Default theme "bright", default settings:
Theme "dark", default settings:
Theme "black", default settings: