This repository has been archived by the owner on May 7, 2020. It is now read-only.
Sonos: play TuneIn by a station id #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kgoderis : could you please review this change ? |
|
Just tried it out - works like a charm for me 👍 |
sjsf
approved these changes
Sep 15, 2017
wborn
reviewed
Sep 15, 2017
| @@ -132,6 +134,8 @@ | |||
|
|
|||
| private Map<String, String> stateMap = Collections.synchronizedMap(new HashMap<String, String>()); | |||
|
|
|||
| private List<SonosMusicService> msuicServices; | |||
There was a problem hiding this comment.
I don't own or use any Sonos devices. But "msuicServices" looks like a typo. :-)
There was a problem hiding this comment.
Good catch :-)
Ah, sorry, don't know where my head is these days... I somehow mixed up Sonos with LIFX... So forget about my testing request unless you can make your bulbs play some music 🤣
Channel table fully updated in the documentation with the access mode added for each channel Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Typo fixed + everything squashed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel table fully updated in the documentation with the access mode added for each channel
Signed-off-by: Laurent Garnier lg.hc@free.fr