This repository has been archived by the owner on May 7, 2020. It is now read-only.
Sonos binding: handle Google Play Music radio #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait, I think I made an unnecessary (wrong) distinction between tunein radio and GPM radio when handling sound notification s. |
Fix #3937 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Change done; ready for review and merge. |
|
Travis is failing in Eclipse SmartHome Core Binding XML Tests on something that cannot have a link with my current change. In my local environment, the Maven build is failing earlier in Eclipse SmartHome Core Tests with something else without any link with my change? I will open an issue for that. |
|
@kgoderis : any chance that you review this little change ? |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
I don't think so. See here: #3912 (comment) |
maggu2810
approved these changes
Aug 9, 2017
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3937
Signed-off-by: Laurent Garnier lg.hc@free.fr