Implemented Option to choose default network interface #3930

triller-telekom · 2017-08-01T15:20:21Z

Signed-off-by: Stefan Triller stefan.triller@telekom.de

triller-telekom · 2017-08-02T07:33:40Z

Close/reopen due to eclipse repository not available...

kaikreuzer

I think there needs to be some cleanup wrt ip address vs network interfaces.
You might also want to check, what other methods might be worthwhile for NetworkInterfaceService - e.g. we could support retrieving the IPv6 address for the primary interface as well as broadcast addresses, etc.

kaikreuzer · 2017-08-02T12:49:51Z

...ig.core/src/main/java/org/eclipse/smarthome/config/core/net/NetworkConfigOptionProvider.java

+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.eclipse.smarthome.config.core.net;


Is there any need to have this in an exported package?

kaikreuzer · 2017-08-02T12:51:06Z

bundles/core/org.eclipse.smarthome.core/ESH-INF/config/networkinterface.xml

+	<config-description uri="system:network">
+		<parameter name="defaultInterface" type="text">
+			<label>Default Interface</label>
+			<description><![CDATA[


No need to put this in a CDATA section.

kaikreuzer · 2017-08-02T12:53:24Z

bundles/core/org.eclipse.smarthome.core/ESH-INF/config/networkinterface.xml

+        http://eclipse.org/smarthome/schemas/config-description-1.0.0.xsd">
+
+	<config-description uri="system:network">
+		<parameter name="defaultInterface" type="text">


Does this parameter really hold a network interface identifier or rather an IPv4 address?
Specifying the interface probably makes sense as it does not have to be updated, if the runtime is assigned a new ip address (on the same interface and subnet) - but this means that your NetworkInterfaceService should also be adapted.

Fixes eclipse-archived#3884 Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

triller-telekom · 2017-08-09T13:25:12Z

rebased against current master to resolve conflicts

kaikreuzer · 2017-08-09T15:03:21Z

bundles/core/org.eclipse.smarthome.core/ESH-INF/config/networkinterface.xml

+		<parameter name="primaryAddress" type="text">
+			<label>Primary Address</label>
+			<description><![CDATA[<p>The primary network to be used</p>
+			<p>Alternative: Enter an IP address (XXX.XXX.XXX.XXX) manually</p>]]></description>


You do not mention the alternative to the alternative :-)

Better say:

A subnet (e.g. 192.168.1.0/24) or an IP address (e.g. 192.168.1.5)

kaikreuzer · 2017-08-09T15:05:41Z

bundles/config/org.eclipse.smarthome.config.core/META-INF/MANIFEST.MF

 Import-Package: com.google.common.base,
 com.google.common.collect,
 com.google.gson,
 org.apache.commons.lang.reflect,
 org.eclipse.jdt.annotation;resolution:=optional,
+ org.apache.commons.net.util,


We imho must not introduce this dependency to the ESH core bundles.

kaikreuzer · 2017-08-09T15:05:51Z

bundles/core/org.eclipse.smarthome.core/META-INF/MANIFEST.MF

@@ -39,6 +39,7 @@ Import-Package: com.google.common.base,
 org.apache.commons.io,
 org.apache.commons.lang,
 org.eclipse.jdt.annotation;resolution:=optional,
+ org.apache.commons.net.util,


We imho must not introduce this dependency to the ESH core bundles.

kaikreuzer · 2017-08-09T15:07:09Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+    @Modified
+    public synchronized void modified(Map<String, Object> config) {
+        String defaultInterfaceConfig = (String) config.get(PRIMARY_ADDRESS);
+        if (defaultInterfaceConfig == null || defaultInterfaceConfig.equals("")) {


better use .isEmpty()

kaikreuzer · 2017-08-09T15:13:55Z

...ipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetworkAddressProvider.java

+ */
+public interface NetworkAddressProvider {
+
+    public String getPrimaryIpv4HostAddress();


How about adding a NonNull annotation? :-)
On an interface, you can remove the "public" keyword.

kaikreuzer · 2017-08-09T15:15:15Z

docs/documentation/development/bindings/thing-handler.md

@@ -180,6 +180,27 @@ Furthermore bindings can specify a localized description of the thing status by
 rate_limit=Device is blocked by remote service for {0} minutes. Maximum limit of {1} configuration changes per {2} has been exceeded. For further info please refer to device vendor.
 ```

+## Offering a callback URL
+
+Some things might require a `callback` URL which should be bound to a certain network interface. A user can configure his default network address via Paper UI under `Configuration -> System -> Network Settings`. To obtain this configured address the `ThingHandlerFactory` needs a `service reference` to the `NetworkInterfaceService` in its `OSGI-INF/MyHandlerFactory.xml`:


Please add a new line for every sentence - this makes diffing and reviews easier.

The correct name seems to be NetworkAddressProvider.
The example is not good, because we by now ask people to use DS annotations, not XML files.

kaikreuzer · 2017-08-09T15:18:36Z

docs/documentation/development/bindings/thing-handler.md

@@ -180,6 +180,27 @@ Furthermore bindings can specify a localized description of the thing status by
 rate_limit=Device is blocked by remote service for {0} minutes. Maximum limit of {1} configuration changes per {2} has been exceeded. For further info please refer to device vendor.
 ```

+## Offering a callback URL


I am not sure whether this is the correct place for the documentation of this feature as the feature is completely independent of bindings. It is often used for the implementation of AudioSinks and potentially other extensions. We should rather have a place for such general system services.

kaikreuzer · 2017-08-09T15:19:51Z

...ng.sonos/src/main/java/org/eclipse/smarthome/binding/sonos/internal/SonosHandlerFactory.java

@@ -171,4 +172,12 @@ protected void unsetAudioHTTPServer(AudioHTTPServer audioHTTPServer) {
        this.audioHTTPServer = null;
    }

+    protected void setNetworkAddressProvider(NetworkAddressProvider networkUtil) {


change networkUtil to networkAddressProvider

kaikreuzer · 2017-08-09T15:20:04Z

...ng.sonos/src/main/java/org/eclipse/smarthome/binding/sonos/internal/SonosHandlerFactory.java

@@ -171,4 +172,12 @@ protected void unsetAudioHTTPServer(AudioHTTPServer audioHTTPServer) {
        this.audioHTTPServer = null;
    }

+    protected void setNetworkAddressProvider(NetworkAddressProvider networkUtil) {
+        this.networkAddressprovider = networkUtil;


change networkAddressprovider to networkAddressProvider

kaikreuzer · 2017-08-09T15:20:11Z

...ng.sonos/src/main/java/org/eclipse/smarthome/binding/sonos/internal/SonosHandlerFactory.java

+        this.networkAddressprovider = networkUtil;
+    }
+
+    protected void unsetNetworkAddressProvider(NetworkAddressProvider networkUtil) {


Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

kaikreuzer · 2017-08-10T15:08:51Z

...rc/main/java/org/eclipse/smarthome/config/core/net/internal/NetworkConfigOptionProvider.java

+    private List<ParameterOption> getIPv4Addresses() {
+        ArrayList<ParameterOption> interfaceOptions = new ArrayList<>();
+
+        HashSet<String> subnets = new HashSet<>();


Change first occurrence to Set

kaikreuzer · 2017-08-10T15:11:18Z

...rc/main/java/org/eclipse/smarthome/config/core/net/internal/NetworkConfigOptionProvider.java

+                    String subNetString = NetUtil.getIpv4NetAddress(ipv4Address, ifAddr.getNetworkPrefixLength()) + "/"
+                            + String.valueOf(ifAddr.getNetworkPrefixLength());
+
+                    subnets.add(subNetString);


Although you didn't add any annotation to NetUtil.getIpv4NetAddress, I assume that subNetString can be null here.

kaikreuzer · 2017-08-10T15:14:04Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+            primaryIP = addrString[0];
+        }
+
+        return primaryIP;


How did you convince your IDE that primaryIP is definitely not null here?

kaikreuzer · 2017-08-10T15:14:23Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

    }

    /**
     * Get the first candidate for a local IPv4 host address (non loopback, non localhost).
     */
+    @Deprecated


Please add a message about what people should now use instead.

kaikreuzer · 2017-08-10T15:15:07Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+     * @param netMask netmask in bits (i.e. 24)
+     * @return network a device is in (i.e. 192.168.5.0)
+     */
+    public static String getIpv4NetAddress(String ipAddressString, short netMask) {


where are the null annotation?

kaikreuzer · 2017-08-10T15:21:47Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

-public class NetUtil {
+@Component(name = "org.eclipse.smarthome.network", property = { "service.config.description.uri=system:network",
+        "service.config.label=Network Settings", "service.config.category=system" })
+public class NetUtil implements NetworkAddressProvider {


Sorry, just realised your name choice now: "Provider" has a very special meaning in many contexts in ESH. NetworkAddressService would probably a more neutral choice.

kaikreuzer · 2017-08-10T15:24:19Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+            String ip = getIPv4inSubnet(primaryAddress);
+            if (ip == null) {
+                // an error has occurred, using first interface like nothing has been configured
+                LOGGER.warn("Error in IP configuration, will continue to use first interface");


Change to:

`"Invalid address '{}', will use first interface instead.", primaryAddress);`

kaikreuzer · 2017-08-10T15:25:40Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+            }
+        } catch (SocketException ex) {
+            LOGGER.error("Could not retrieve network interface: {}", ex.getMessage(), ex);
+            return null;


this line is superfluous.

kaikreuzer · 2017-08-10T15:29:13Z

docs/documentation/features/providedServices.md

+
+In this chapter useful services of the Eclipse SmartHome project are described. 
+
+## Obtaining the default IP address


Use the service name for the header: "Network Address Service" or something like that.

kaikreuzer · 2017-08-10T15:30:05Z

.../main/java/org/eclipse/smarthome/binding/sonos/discovery/ZonePlayerDiscoveryParticipant.java

@@ -29,6 +30,7 @@
 *
 * @author Karel Goderis - Initial contribution
 */
+@Component(name = "org.eclipse.smarthome.binding.sonos.discovery.zoneplayer", immediate = true)


Afaik, we do not need a specific service name for that one, so I'd suggest to go for the default and remove that name property here.

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

kaikreuzer · 2017-08-11T09:38:09Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+     * @param netMask netmask in bits (i.e. 24)
+     * @return network a device is in (i.e. 192.168.5.0)
+     */
+    public static @NonNull String getIpv4NetAddress(@NonNull String ipAddressString, short netMask) {


If you want to assure to always return valid non-null results, you should at least also throw IllegalArgumentExceptions. Or what would you return if I pass you "ABC" as my ipAddressString?

kaikreuzer · 2017-08-11T09:38:49Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+        String[] ipv4AddressOctets = ipAddressString.split("\\.");
+        String netAddress = "";
+        for (int i = 0; i < 4; i++) {
+            netAddress += Integer.parseInt(ipv4AddressOctets[i]) & Integer.parseInt(netMaskOctets[i]);


You'll need to catch NumberFormatException - this should not bubble up in the call stack.

kaikreuzer · 2017-08-11T09:39:18Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+     * @param netMask netmask in bits (i.e. 24)
+     * @return network a device is in (i.e. 192.168.5.0)
+     */
+    public static @NonNull String getIpv4NetAddress(@NonNull String ipAddressString, short netMask) {


This method is a wonderful candidate for a couple of unit tests!

kaikreuzer · 2017-08-11T09:41:14Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+
+    private String primaryAddress;
+
+    @SuppressWarnings("unchecked")


kaikreuzer · 2017-08-11T09:42:11Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+    private String primaryAddress;
+
+    @SuppressWarnings("unchecked")
+    protected void activate(ComponentContext componentContext) {


Instead of pulling the properties out of the context, why don't you simply implement activate(Map<String, Object> props)?

kaikreuzer · 2017-08-11T09:46:16Z

...lipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetworkAddressService.java

+public interface NetworkAddressService {
+
+    @Nullable
+    String getPrimaryIpv4HostAddress();


please add JavaDoc

kaikreuzer · 2017-08-11T09:46:35Z

docs/documentation/features/frameworkUtilities.md

+layout: documentation
+---
+
+# Provided Services


Shouldn't it now say "Framework Utilities"?

kaikreuzer · 2017-08-11T09:47:19Z

docs/documentation/features/frameworkUtilities.md

+## Network Address Service
+
+A user can configure his default network address via Paper UI under `Configuration -> System -> Network Settings`.
+To obtain this configured address the `ThingHandlerFactory` needs a `service reference` to the `NetworkAddressService` in its `MyHandlerFactory.java`:


This is still binding specific doc

kaikreuzer · 2017-08-11T09:48:25Z

docs/documentation/features/frameworkUtilities.md

+To obtain this configured address the `ThingHandlerFactory` needs a `service reference` to the `NetworkAddressService` in its `MyHandlerFactory.java`:
+
+```java
+@Reference


Do you really think we need to explain how OSGi DS works for every single service we offer?
Wouldn't it be more important to state that the NetworkAddressService IS an OSGi service that can be used?

kaikreuzer · 2017-08-11T09:49:54Z

docs/documentation/features/frameworkUtilities.md

+```
+
+Now the `MyHandlerFactory` can obtain the configured IP address via `networkAddressService.getPrimaryIpv4HostAddress()`.
+This IP address can for example be used for things (i.e. AudioSinks) that require a callback URL which they can offer to a device.


No, examples are ThingHandlerFactory and AudioSink implementations. (note: thing!=AudioSink)

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

kaikreuzer · 2017-08-11T14:01:51Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+        String primaryAddressConf = (String) config.get(PRIMARY_ADDRESS);
+        if (primaryAddressConf == null || primaryAddressConf.isEmpty() || !isValidIPConfig(primaryAddressConf)) {
+            // if none is specified we return the default one for backward compatibility
+            LOGGER.warn("Non valid IP configuration found, will continue to use first interface");


As >90% of users will have exactly one interface, there is no need to set this configuration parameter.
Why should you bother them with a warning?
You should only show a warning if the parameter is invalid.

kaikreuzer · 2017-08-11T14:03:36Z

...es/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetUtil.java

+                + "' out of bounds (1-31)";
+
+        if (!isValidIPConfig(ipAddressString) || netMask < 1 || netMask > 31) {
+            throw new IllegalArgumentException(errorString);


You should mention this exception in the JavaDoc.

kaikreuzer · 2017-08-11T14:05:18Z

...lipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/net/NetworkAddressService.java

+    /**
+     * Returns the user configured primary IPv4 address of the system
+     * 
+     * @return IPv4 address as a String in format xxx.xxx.xxx.xxx


.. or null if bla bla bla...?

kaikreuzer · 2017-08-11T14:09:17Z

docs/documentation/features/frameworkUtilities.md

+## Network Address Service
+
+A user can configure his default network address via Paper UI under `Configuration -> System -> Network Settings`.
+The `NetworkAddressService` is an OSGi service that can be used like any other OSGi service by adding a service reference to it.


This should be the first sentence of the paragraph. Maybe also mention that it is a configurable service, mentioning its service id. The Paper UI example above is then just one way - in general anything that uses ConfigurationAdmin can be used to configure the service.

kaikreuzer · 2017-08-11T14:10:56Z

...rc/main/java/org/eclipse/smarthome/config/core/net/internal/NetworkConfigOptionProvider.java

+                    }
+
+                    String ipv4Address = addr.getHostAddress();
+                    String subNetString = NetUtil.getIpv4NetAddress(ipv4Address, ifAddr.getNetworkPrefixLength()) + "/"


What do you do if this now throws the newly introduced IllegalArgumentException?

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

triller-telekom · 2017-08-11T16:31:30Z

close/reopen because of unreachable maven repo

kaikreuzer

Thanks - just some last comments, but nothing that prevents merging it now.

kaikreuzer · 2017-08-11T17:06:16Z

...rg.eclipse.smarthome.core.test/src/test/java/org/eclipse/smarthome/core/net/NetUtilTest.java

+
+        try {
+            network = NetUtil.getIpv4NetAddress("192.168.5.8", (short) 32);
+            ;


Is this line required?

kaikreuzer · 2017-08-11T17:08:07Z

...rg.eclipse.smarthome.core.test/src/test/java/org/eclipse/smarthome/core/net/NetUtilTest.java

+            ;
+        } catch (IllegalArgumentException iae) {
+            assertThat(iae.getMessage(),
+                    is("IP '192.168.5.8' not a valid IPv4 address or netmask '32' out of bounds (1-31)"));


I would actually except a clear message about the error and not "this or that is wrong".

"Netmask '32' is out of bounds (1-31)"

Would be the expected result, do you agree?

kaikreuzer · 2017-08-11T17:09:00Z

...rg.eclipse.smarthome.core.test/src/test/java/org/eclipse/smarthome/core/net/NetUtilTest.java

+            network = NetUtil.getIpv4NetAddress("192.168.58", (short) 24);
+        } catch (IllegalArgumentException iae) {
+            assertThat(iae.getMessage(),
+                    is("IP '192.168.58' not a valid IPv4 address or netmask '24' out of bounds (1-31)"));


"IP '192.168.58' is not a valid IPv4 address."

kaikreuzer · 2017-08-11T17:09:12Z

...rg.eclipse.smarthome.core.test/src/test/java/org/eclipse/smarthome/core/net/NetUtilTest.java

+            network = NetUtil.getIpv4NetAddress("SOME_TEXT", (short) 24);
+        } catch (IllegalArgumentException iae) {
+            assertThat(iae.getMessage(),
+                    is("IP 'SOME_TEXT' not a valid IPv4 address or netmask '24' out of bounds (1-31)"));


"IP 'SOME_TEXT' is not a valid IPv4 address"

kaikreuzer · 2017-08-11T17:23:25Z

...rc/main/java/org/eclipse/smarthome/config/core/net/internal/NetworkConfigOptionProvider.java

+
+                    String ipv4Address = addr.getHostAddress();
+                    try {
+                        // InetAddress.getHostAddress() is missing a @NonNull annotation


You can make it clear by code, which conversion you are suppressing - no need for this comment. Just do above the following:

@SuppressWarnings("null") @NonNull String ipv4Address = addr.getHostAddress();

I think that is the better style we should follow.

triller-telekom force-pushed the networkChooser branch from 617471b to c355177 Compare August 2, 2017 07:06

triller-telekom closed this Aug 2, 2017

triller-telekom reopened this Aug 2, 2017

kaikreuzer suggested changes Aug 2, 2017

View reviewed changes

kaikreuzer added the Core label Aug 2, 2017

triller-telekom force-pushed the networkChooser branch from d213661 to 8054c64 Compare August 3, 2017 15:40

Implemented Option to choose default network interface

5875895

Fixes eclipse-archived#3884 Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

triller-telekom force-pushed the networkChooser branch from 8054c64 to 5875895 Compare August 9, 2017 13:24

kaikreuzer suggested changes Aug 9, 2017

View reviewed changes

triller-telekom added 3 commits August 10, 2017 14:50

Removed dependency to apache.commons.net + use DS annotations

b0099bf

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

Store subnets and temporarily limit to options

0d0bb6b

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

Link documentation in menu

b841acf

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

kaikreuzer suggested changes Aug 10, 2017

View reviewed changes

triller-telekom added 2 commits August 11, 2017 10:38

renamed NetworkAddressProvider to NetworkAddressService

12bb82b

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

Use List instead of ArrayList for variable definition

a4067e3

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

kaikreuzer suggested changes Aug 11, 2017

View reviewed changes

Added jUnit test and Javadocs

aedbf21

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

kaikreuzer suggested changes Aug 11, 2017

View reviewed changes

More tests

041e897

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

triller-telekom closed this Aug 11, 2017

triller-telekom reopened this Aug 11, 2017

kaikreuzer approved these changes Aug 11, 2017

View reviewed changes

kaikreuzer merged commit 0c4353e into eclipse-archived:master Aug 11, 2017

triller-telekom deleted the networkChooser branch August 14, 2017 06:21

triller-telekom mentioned this pull request Aug 17, 2017

Add optional org.eclipse.jdt.annotation dependency to binding bundles openhab/openhab-addons#2556

Merged

maggu2810 mentioned this pull request Sep 6, 2017

NetUtil: Netmask '32' is out of bounds #4205

Closed

triller-telekom mentioned this pull request Sep 12, 2017

Core/Network: Allow IPv6 for default network interface. #4218

Merged

kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

kaikreuzer added the enhancement label Dec 15, 2017


		In this chapter useful services of the Eclipse SmartHome project are described.

		## Obtaining the default IP address


		private String primaryAddress;

		@SuppressWarnings("unchecked")

Implemented Option to choose default network interface #3930

Implemented Option to choose default network interface #3930

Conversation

triller-telekom commented Aug 1, 2017 • edited

triller-telekom commented Aug 2, 2017

kaikreuzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triller-telekom commented Aug 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triller-telekom commented Aug 11, 2017

kaikreuzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triller-telekom commented Aug 1, 2017 •

edited