This repository has been archived by the owner on May 7, 2020. It is now read-only.
Allow JSR223 scripts with same name in different directories #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-archived#3801 Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
|
@smerschjohann: Was there a specific reason for just comparing the filename and not the whole path? Because in the whole |
|
closed/reopened for travis rebuild |
|
I would assume that the reason was that he derived the UIDs from the file name and thus wanted to rule out any duplicates. As we are by now generating a UUID, I would hope that this is no issue anymore, so your change should be fine (@smerschjohann, please correct me, if I am wrong). |
|
yes, you are right. It was a bad idea to rely only one the filename. I did not think about the "same name in different directories" case. Thanks for this |
5iver
pushed a commit
to 5iver/openhab-core
that referenced
this pull request
Apr 15, 2019
Currently, the scripts are loaded based on the lexicographical order of the absolute paths of the scripts. This makes it difficult to control the load order. This change bases the load order solely on the filename, as was originally used before eclipse-archived/smarthome#3855, and preserves the ability to use scripts with the same filename. Signed-off-by: Scott Rushworth <openhab@5iver.com>
maggu2810
pushed a commit
to openhab/openhab-core
that referenced
this pull request
Apr 18, 2019
Currently, the scripts are loaded based on the lexicographical order of the absolute paths of the scripts. This makes it difficult to control the load order. This change bases the load order solely on the filename, as was originally used before eclipse-archived/smarthome#3855, and preserves the ability to use scripts with the same filename. Signed-off-by: Scott Rushworth <openhab@5iver.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3801
Signed-off-by: Stefan Triller stefan.triller@telekom.de