This repository has been archived by the owner on May 7, 2020. It is now read-only.
[astro] Tidy up set of scheduled futures #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in order to not keep useless references to finished jobs in the collections. It's taking the opportunity for tyding up every time a new job gets scheduled. In that way, the job's runnables don't have to be cluttered with these internals of the handler. Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
kaikreuzer
approved these changes
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in order to not keep useless references to finished jobs in the collections.
It's taking the opportunity for tidying up every time a new job gets scheduled.
In that way, the job's runnables don't have to be cluttered with these
internals of the handler.
Note: while it is in principle is similar to #3809, the current version since #3776 does not cause such troubles anymore. So this PR is mainly about freeing a little bit of memory.
Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com