This repository has been archived by the owner on May 7, 2020. It is now read-only.
Sonos binding: add state description on few channels #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait for the end of discussion in the issue. Maybe this PR is not necessary if I provide a more general solution. |
|
just adding the "feedback" label to mark it as blocked |
|
I propose to merge it before the next release if no general fix is merged at this time. |
|
This PR may be closed and abandoned when #3822 is merged. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
changed the title
|
@SJKA : I changed the focus of this PR to simply add a state description on channels that require one (mainly for read-only channels) and reorder the channels in alphabetic order (few of them were previously added by me at the end of the file). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr