This repository has been archived by the owner on May 7, 2020. It is now read-only.
Break circle dependency in GroupItem members #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsf
suggested changes
Jul 4, 2017
| @@ -116,6 +116,9 @@ public GroupFunction getFunction() { | |||
|
|
|||
| private void collectMembers(Set<Item> allMembers, Set<Item> members) { | |||
| for (Item member : members) { | |||
| if (allMembers.contains(member)) { | |||
| return; | |||
There was a problem hiding this comment.
how about continue instead of return? 😉
There was a problem hiding this comment.
Just noticed that and changed the code but your continue is even better ;)
Well... that is only if I swap the allMembers.put and the recursive call too... So I think the if I have used now should be fine
triller-telekom
force-pushed
the
groupItemCircleDependency
branch
from
6024db6
to
c88d449
Compare
Fixes eclipse-archived#3794 Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
triller-telekom
force-pushed
the
groupItemCircleDependency
branch
from
c88d449
to
9014da6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3794
Signed-off-by: Stefan Triller stefan.triller@telekom.de