This repository has been archived by the owner on May 7, 2020. It is now read-only.
LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things file #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file Signed-off-by: Wouter Born <eclipse@maindrain.net>
kaikreuzer
approved these changes
Jun 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #3745 using
powerOnBrightness=in a .things file no longer works. Such files nowadays fail validation, e.g. the following warning is logged:After testing it shows that removing the default for the
powerOnBrightnessparameter makes it again possible to switch lights on without changing the brightness when thepowerOnBrightnessparameter in .things files is omitted.