This repository has been archived by the owner on May 7, 2020. It is now read-only.
Basic UI: escape HTML characters #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@resetnow : this one is for you ,) |
| @@ -82,7 +82,8 @@ public boolean canRender(Widget w) { | |||
| String button = getSnippet("button"); | |||
| button = StringUtils.replace(button, "%item%", w.getItem()); | |||
| button = StringUtils.replace(button, "%cmd%", mapping.getCmd()); | |||
There was a problem hiding this comment.
I think we need escape here as well. Test case:
Switch item=DemoString mappings=["value__1"="description_1", "value_\"_2"="description_2"]
There was a problem hiding this comment.
Also, using StringEscapeUtils.escapeHTML here is probably not the right choice — only quotes and backslashes need to be prepended with \ so resulting HTML attribute has correct value when it's being read from Javascript.
There was a problem hiding this comment.
I thought about mappings from number or ON/OFF/OPEN/CLOSE... for example but not from a general string.
You're right, it has to be tested and fixed for general string commands too.
Fix #3744 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Fixed. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3744
Signed-off-by: Laurent Garnier lg.hc@free.fr