[#531] Update to Hono 2.5.1. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calohmn
commented
May 9, 2024
Comment on lines
-669
to
-671
| The native executables used in the images currently do not properly detect the memory and CPU resource limits defined on the | ||
| container. This is due to a bug in the native-image builder in GraalVM versions before 22.1. Future versions of Hono will | ||
| probably not be affected by this anymore. |
There was a problem hiding this comment.
@sophokles73 I guess this can be removed as the HonoBuilder.dockerfile uses Mandrel/GraalVM version 23.0.2.1-Final now. Is that correct?
sophokles73
approved these changes
May 15, 2024
Comment on lines
-669
to
-671
| The native executables used in the images currently do not properly detect the memory and CPU resource limits defined on the | ||
| container. This is due to a bug in the native-image builder in GraalVM versions before 22.1. Future versions of Hono will | ||
| probably not be affected by this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531 .