Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments missing toleration options #527

Open
geh1sf opened this issue Apr 15, 2024 · 1 comment
Open

Deployments missing toleration options #527

geh1sf opened this issue Apr 15, 2024 · 1 comment

Comments

@geh1sf
Copy link

geh1sf commented Apr 15, 2024

Hello Team,

Upon reviewing your template files for deployments and stateful sets, I noticed that they lack a specification for tolerations.

Integrating tolerations is crucial if you aim to dedicate a specific group of nodes exclusively for Hono services. While affinity rules are beneficial, they do not prevent other resources from being scheduled on these nodes.

To address this, I suggest incorporating the following line to ensure that only the intended workloads run on the designated nodes:

{{- include "hono.pod.tolerations" $args | nindent 6 }}

This small change will enhance our configuration's precision in resource allocation and maintain operational integrity.

@sophokles73
Copy link
Member

We would be happy to accept a PR :-)

@sophokles73 sophokles73 changed the title Deployments missing tolleration options Deployments missing toleration options May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants