-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui request: support configuring backend host name #706
Comments
Hi @davidxia, the |
Thanks! So running the webui separately is only for development? Might be nice to document the right way to deploy the app. |
Yes, it's so that you don't have to restart the server every time you make a small change to the webui.
Deployment documentation can be found here: https://github.com/eclipse/openvsx/wiki/Deploying-Open-VSX. However, I don't know if it is still up to date. |
@amvanbaren Just FYI, I just noticed |
From https://github.com/eclipse/openvsx/wiki/Deploying-Open-VSX#adding-the-web-ui: You can create a new package and define your own |
Hi @davidxia, did you manage to get openvsx running? #703 (comment) might help. |
Thanks for asking. I got it running but had to make some small hardcoded changes to do the above. Might be nice to update the docs and accommodate my use case, but I’m also OK if this issue is closed. |
Hello @davidxia, Here is the error I am getting in the web browser console when opening https://openvsx.foo.com:
Actually. I cannot find the file |
I'd be happy to do that @davidxia. Can you share the changes you've made? |
Sorry for late reply. These are the changes I made. It's been a while so I'm hazy on why exactly I made these specific ones. |
Can you support configuring the backend host name in the webui code here? I have the constraint that I can't use ports and must deploy the webui to
https://open-vsx.foo.com
and the server tohttps://open-vsx-server.foo.com
. So I'd like to configureserverHost = 'open-vsx-server.foo.com'
. Right now the webui code assumes the server is running on the same host name.I can contribute a PR if someone can guide me on the best way to parameterize this.
The text was updated successfully, but these errors were encountered: