New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LanguageServerWrapper: initialProject/initialPath won't be updated when a new LS gets started #683
Comments
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jun 8, 2023
For some LS the determination of LS initialization options depends on the first uri to be opened and not on the first project or path. Therefor the getInitializationOptionsFromUri(URI) method has been added to the StreamConnectionProvider interface. It will be called when getInitializationOptions(URI) returns null. fixes eclipse#683 eclipse#684
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jun 8, 2023
For some LS the determination of LS initialization options depends on the first uri to be opened and not on the first project or path. Therefor the getInitializationOptionsFromUri(URI) method has been added to the StreamConnectionProvider interface. It will be called when getInitializationOptions(URI) returns null. fixes eclipse#683 eclipse#684
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jun 8, 2023
For some LS the determination of LS initialization options depends on the first uri to be opened and not on the first project or path. Therefor the getInitializationOptionsFromUri(URI) method has been added to the StreamConnectionProvider interface. It will be called when getInitializationOptions(URI) returns null. fixes eclipse#683 eclipse#684
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jun 12, 2023
For some LS the determination of LS initialization options depends on the first uri to be opened and not on the first project or path. Therefor the getInitializationOptionsFromUri(URI) method has been added to the StreamConnectionProvider interface. It will be called when getInitializationOptions(URI) returns null. fixes eclipse#683 eclipse#684
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jun 12, 2023
For some LS the determination of LS initialization options depends on the first uri to be opened and not on the first project or path. Therefor the getInitializationOptionsFromUri(URI) method has been added to the StreamConnectionProvider interface. It will be called when getInitializationOptions(URI) returns null. fixes eclipse#683 eclipse#684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the LS gets terminated by
org.eclipse.lsp4e.LanguageServerWrapper.stop()
and a new server gets started later on byorg.eclipse.lsp4e.LanguageServerWrapper.stop()
the project or path differ in case a document of a different project/path will be opened.This can lead to problems when a new LS instance will be started with outdated
rootUri
A solution would be, to offer a new start method in the wrapper with
rootUri
as argument. This was also suggested in #157:org.eclipse.lsp4e.LanguageServerWrapper.start(URI rootUri)
The text was updated successfully, but these errors were encountered: