Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immutablePetCountsByEmoji in PetKata; update slides.md with solutions and corrected methods #348

Open
darshitpp opened this issue Sep 28, 2023 · 0 comments

Comments

@darshitpp
Copy link

Currently, the method immutablePetCountsByEmoji has incorrect Assertion on a Map.

Assertions.assertEquals(
        Map.of("馃惐", 2L, "馃惗", 2L, "馃惞", 2L, "馃悕", 1L, "馃悽", 1L, "馃惁", 1L),
        countsByEmoji
);

Here, the assertion parameter of the Map, and the refactor for countsByEmoji both need to be changed to solve the kata, which ideally should not be the case.

Additionally, the solution in slides.md itself refers to an outdated test not present in the Test Class.

Some other solutions within the same slides.md need to be refactored to have better naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant