Block-wise transfer on observe response?

[H732948]

Hello,

I have a wakaama client that sometimes sends large responses as the result of observation notifications, and there is no block-wise transfer initiated. I see that block2 is implemented on the server side for observe, but I couldn't see that it was implemented on the client side. I'm not sure if I missed something or misunderstand how it's supposed to work?

I added this in observe.c, line 807, to make my client initiate block-wise transfer for payloads larger than REST_MAX_CHUNK_SIZE:

if (length > REST_MAX_CHUNK_SIZE){
coap_set_header_block2(message, 0, (length > REST_MAX_CHUNK_SIZE), REST_MAX_CHUNK_SIZE);
coap_set_payload(message, buffer, REST_MAX_CHUNK_SIZE);
}
else
{
coap_set_payload(message, buffer, length);
}

It seems to work well. Am I missing something or might this be a good addition to observe.c?

[LukasWoodtli]

@H732948 It's possible that something is missing. Would you consider providing a PR?