Skip to content

Latest commit

 

History

History
82 lines (63 loc) · 3.44 KB

CONTRIBUTING.md

File metadata and controls

82 lines (63 loc) · 3.44 KB
Raw

How to Contribute to Eclipse Velocitas License Check

First of all, thanks for considering to contribute to Eclipse Velocitas. We really appreciate the time and effort you want to spend helping to improve things around here.

In order to get you started as fast as possible we need to go through some organizational issues first, though.

Eclipse Contributor Agreement

Before your contribution can be accepted by the project team contributors must electronically sign the Eclipse Contributor Agreement (ECA).

Commits that are provided by non-committers must have a Signed-off-by field in the footer indicating that the author is aware of the terms by which the contribution has been provided to the project. The non-committer must additionally have an Eclipse Foundation account and must have a signed Eclipse Contributor Agreement (ECA) on file.

For more information, please see the Eclipse Committer Handbook: https://www.eclipse.org/projects/handbook/#resources-commit

Code Style Guide

  • Use Ruff to format your code.
  • Use mypy to check for type errors.
  • Above and other tools will run automatically if you install pre-commit using the instructions below.

Prerequisities

  • Visual Studio Code
  • Remote Containers extension

Making Your Changes

  • Fork the repository on GitHub.
  • Open the repository in Visual Studio Code using the provided devcontainer.
  • Create a new branch for your changes.
  • Make your changes following the code style guide (see Code Style Guide section above).
  • When you create new files make sure you include a proper license header at the top of the file (see License Header section below).
  • Make sure you include test cases for non-trivial features.
  • Make sure test cases provide sufficient code coverage (> 70% on new code)
  • Make sure the unit tests pass after your changes.
  • Run the action locally in a state compareable to a Github runner, execute: 
    run-container.sh
  • Commit your changes into that branch.
  • Use descriptive and meaningful commit messages. Start the first line of the commit message with the issue number and title e.g. [#9865] Add token based authentication.
  • Squash multiple commits that are related to each other semantically into a single one.
  • Make sure you use the -s flag when committing as explained above.
  • Push your changes to your branch in your forked repository.

License Header

Please make sure any file you newly create contains a proper license header like this:

# Copyright (c) <year> Contributors to the Eclipse Foundation
#
# This program and the accompanying materials are made available under the
# terms of the Apache License, Version 2.0 which is available at
# https://www.apache.org/licenses/LICENSE-2.0.
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# SPDX-License-Identifier: Apache-2.0

Please adjusted the comment character to the specific file format.

Submitting the Changes

Submit a pull request via the normal GitHub UI.

After Submitting

  • Do not use your branch for any other development, otherwise further changes that you make will be visible in the PR.