Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of response messages #112

Closed
sophokles73 opened this issue Apr 10, 2024 · 2 comments
Closed

Definition of response messages #112

sophokles73 opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@sophokles73
Copy link
Contributor

This is the continuation of eclipse-uprotocol/up-core-api#77
after up-core-api has been merged into up-spec as part of #91

@stevenhartley
Copy link
Contributor

@sophokles73 , this PR requries an update to USubscription, Udiscovery, and UTwin protos, do we push this till after 1.5.8 or do you have a Pr for it now?

sophokles73 added a commit to SoftwareDefinedVehicle/uprotocol-spec-fork that referenced this issue May 23, 2024
stevenhartley pushed a commit that referenced this issue May 24, 2024
* [#112] Add RPC response message usage definition

* Use empty response message
sophokles73 added a commit to SoftwareDefinedVehicle/uprotocol-spec-fork that referenced this issue May 27, 2024
Changed operation definitions of uProtocol core services to always
use dedicated request and response messages as recommended by
Protobuf Best Practices.

Removed UStatus from response messages, following recommendations
from uProtocol Error Model specification.
stevenhartley pushed a commit that referenced this issue May 28, 2024
* [#112] Use dedicated messages in service operations

Changed operation definitions of uProtocol core services to always
use dedicated request and response messages as recommended by
Protobuf Best Practices.

Removed UStatus from response messages, following recommendations
from uProtocol Error Model specification.

* Add documentation
@stevenhartley
Copy link
Contributor

Closing as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants