Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hashes for Theia Blueprint downloads #307

Open
DamnedElric opened this issue Oct 2, 2023 · 4 comments
Open

Provide hashes for Theia Blueprint downloads #307

DamnedElric opened this issue Oct 2, 2023 · 4 comments
Assignees

Comments

@DamnedElric
Copy link

The download page for the blueprint desktop edition does not provide any cryptographic hashes for the downloads. This is particularly problematic because the download redirects to a random local-ish mirror, e.g. https://ftp.fau.de/eclipse/theia/latest/linux/TheiaBlueprint.AppImage, which is not a URL I would immediately trust.

Please publish, for example, SHA-256 or SHA-512 hashes along with the download links.

Many thanks

@jfaltermeier
Copy link
Contributor

Thanks for the report. I will move the issue to the blueprint repository, so that we may publish the hash as part of the build.
For now, that latest directories should contain a latest file including a SHA-512 hash, that is used by the updater, e.g. https://download.eclipse.org/theia/latest/linux/latest-linux.yml

@jfaltermeier jfaltermeier transferred this issue from eclipse-theia/theia-website Oct 4, 2023
@jfaltermeier jfaltermeier self-assigned this Oct 4, 2023
@marcdumais-work
Copy link
Contributor

Maybe the theia-ide.org Blueprint download page should point to the OS-specific download folders [1] instead of the current direct download link? Then it will be "discoverable" that there are checksum provided?

[1]: e.g.:
https://download.eclipse.org/theia/latest/windows/
https://download.eclipse.org/theia/latest/linux/
https://download.eclipse.org/theia/latest/macos/

@jfaltermeier
Copy link
Contributor

The current links on the Download page are of this form: https://www.eclipse.org/downloads/download.php?file=/theia/latest/windows/TheiaBlueprint.exe&r=1 This makes sure that the download stats are recorded.
See #36 (comment) for more info. This would be lost when linking to the directories

@marcdumais-work
Copy link
Contributor

Then maybe we could add, along with the download links, also links for the corresponding files that contain the hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants