Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Improve Blueprint versioning, tag the releases #303

Open
PatrikN-work opened this issue Sep 26, 2023 · 6 comments
Open

[CM] Improve Blueprint versioning, tag the releases #303

PatrikN-work opened this issue Sep 26, 2023 · 6 comments

Comments

@PatrikN-work
Copy link

PatrikN-work commented Sep 26, 2023

Feature Description:

Please tag the releases aswith ordinary Theia. The last tag is 3 years old.

Without this it is really hard to keep track of versions

@marcdumais-work marcdumais-work changed the title Please tag the releases [CM] Please tag the releases Sep 27, 2023
@marcdumais-work
Copy link
Contributor

marcdumais-work commented Sep 27, 2023

Indeed, we have an initial v0.0.1 tag in the repo, and that's it:
image

Related - ATM we only manually step the version of the Blueprint app, when we update the Theia version. Between these updates, any PR merged, we release new Blueprint packages, that re-uses the same version number.

Probably we should step the version for "in-between" releases, so it's possible to distinguish between them and "official" releases? And also tag "official" releases in the repo (a requirement for at least some companies that want a tag, to fetch the sources of a specific version for analysis)? Also it probably would not hurt to include the version in the package names. i.e. how do we know which version are these?

To recap:

  • step Blueprint version in each app's package.json for each release. e.g. use Theia's version as is done now, but step the minor patch/bugfix version for each merged PR (note: this may sometimes clash with Theia stepping its own patch version, e.g. for community releases or the occasional bugfix release)
  • add a tag in the repo for each "official" release (1.41.0, 1.42.0, ...)
  • include version in package names?

@marcdumais-work marcdumais-work changed the title [CM] Please tag the releases [CM] Improve Blueprint versioning, tag the releases Sep 27, 2023
@marcdumais-work
Copy link
Contributor

cc: @tsmaeder @planger WDYT?

@marcdumais-work
Copy link
Contributor

As a temporary work-around, are there any objections, to me manually adding a git tag for 1.41.0?

@planger
Copy link
Contributor

planger commented Oct 3, 2023

I'm not really familiar with the current release process of Blueprint, probably @jfaltermeier should chime in on that!
In general I don't have any objection to tag manually for now. But on the long run, it'd be good to have an automated workflow that creates a Github release and that tags the git ref from which the version has been built.

@jfaltermeier
Copy link
Contributor

Currently each commit on master triggers a build that will be released.
I agree that for now we can add tags manually, but we should look for an automated solution including version increments for each published version.

@marcdumais-work
Copy link
Contributor

release tag manually added: v1.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants