Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow For Changing User Email Address #242

Closed
maierthomas opened this issue Apr 26, 2018 · 2 comments · Fixed by #258
Closed

Allow For Changing User Email Address #242

maierthomas opened this issue Apr 26, 2018 · 2 comments · Fixed by #258
Assignees
@alexbrdn
Labels
bug Something isn't working enhancement New feature or request

Comments

@maierthomas
Copy link
Contributor

maierthomas commented Apr 26, 2018 •
edited by alexbrdn

Issue by alexbrdn
Friday Mar 23, 2018 at 09:30 GMT
Originally opened as sw360/sw360portal#795

sw360 should recognize when an email address of a user has changed and preserve the identity.

Criteria for email address change is that the Liferay user with the same externalId (field openId) has a different email address than the sw360 user with the same externalId.
Email change in Liferay is performed by LDAP importer or SSOAutoLogin action.

  • when email changes, user's email should be updated and the old email moved into the list of previous email addresses of the user
  • migration script necessary to replace all users' ids with generic ids instead of emails
  • couchdb indexes should be built by field email address and by previous email addresses
  • user search by email address should try searching by email address and fall back to searching by previous email address field
@maierthomas maierthomas added bug Something isn't working enhancement New feature or request labels Apr 26, 2018
@maierthomas
Copy link
Contributor Author

Comment by maxhbr
Friday Mar 23, 2018 at 16:01 GMT

The same approach could maybe be used for licenses

alexbrdn added a commit that referenced this issue Apr 30, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
5af6a74 
…reviously known email addresses and falling back to search by former addresses when necessary

closes #242
@alexbrdn
Copy link
Contributor

@maierthomas, how would the switch to guids as user ids affect REST API?

/cc @maxhbr

alexbrdn added a commit that referenced this issue Apr 30, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
503fe9f 
…reviously known email addresses and falling back to search by former addresses when necessary

closes #242
alexbrdn added a commit that referenced this issue May 2, 2018
@alexbrdn
fix(users): introduce generic ids for users instead of using emails a…
3da49c1 
…s ids

closes #242
@alexbrdn alexbrdn mentioned this issue May 2, 2018
Merged
alexbrdn added a commit that referenced this issue May 2, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
85b3923 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 2, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
24fedf1 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 3, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
d423983 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 7, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
cce803d 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 7, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
a5a95d2 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 11, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
5cdea8e 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 14, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
842fe0f 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
alexbrdn added a commit that referenced this issue May 15, 2018
@alexbrdn
fix(users): handle external change of user email address by storing p…
54e5286 
…reviously known email addresses and falling back to search by former addresses when necessary

introduce generic ids for users instead of using emails as ids

closes #242
mcjaeger added a commit that referenced this issue May 15, 2018
@mcjaeger
Merge pull request #258 from eclipse/alexbrdn/#242/user-email-change
228778a 
Allow For Changing User Email Address

review-by:maximilian.huber@tngtech.com
tested-by:michael.c.jaeger@siemens.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbrdn alexbrdn

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow For Changing User Email Address eclipse-sw360/sw360
3 participants
@bs-jokri @alexbrdn @maierthomas