Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--add-exports java.base/jdk.internal.misc=ALL-UNNAMED - please fix the docs! #186

Open
hrstoyanov opened this issue Mar 28, 2024 · 0 comments

Comments

@hrstoyanov
Copy link

hrstoyanov commented Mar 28, 2024

Environment Details

  • EclipseStore Version: 1.3.1
  • JDK version: 21.0.2
  • OS: MacSO Sonoma 14.3.1

Describe the bug

The EclipseStore documentation says that in order to enable persistence for Java records, one need to run the JVM with:

--add-exports java.base/jdk.internal.misc=ALL-UNNAMED

That does not solve the issue in all cases, and I found out that when using fully modularized app, one needs to actually use:

--add-exports java.base/jdk.internal.misc=java.base/jdk.internal.misc=org.eclipse.serializer.base

So, you may want to document both options?

Additional context

If you read the Java 21 docs for Javac ALL-UNAMED works for unnamed/legacy jars only :

--add-exports module/package=other-module(,other-module)*

Specifies a package to be considered as exported from its defining module to additional modules or to all unnamed modules when the value of other-module is ALL-UNNAMED.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant